Closed
Conversation
cmyr
approved these changes
Jun 15, 2022
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Thanks, and yes I agree that 0.6.0 is the right call.
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Update dependencies explicitly to the latest compatible versions
These are all semver compatible changes. These are versions that Cargo resolves to anyway, which also means they're the versions we actually test with. For the curious I've written more about the rationale for doing this in the Druid CONTRIBUTING.md.
Increase Piet version to v0.6.0
Straightforward, with the only question being if it should be v0.5.1 or v0.6.0. When I went over all the changes it seemed like the choice of v0.6.0 was clear. One example is #494 which updated
imagefrom0.23to0.24. Some of the Piet API exposes this crate and so by extension the Piet API changed.